[PATCH RFC 01/10] qemu_tpm: Make APIs work over a single virDomainTPMDef

[Daniel P. Berrangé]

On Mon, May 09, 2022 at 05:02:08PM +0200, Michal Privoznik wrote:
> In qemu_extdevice.c lives code that handles helper daemons that
> are required for some types of devices (e.g. virtiofsd,
> vhost-user-gpu, swtpm, etc.). These devices have their own
> handling code in separate files, with only a very basic functions
> exposed (e.g. for starting/stopping helper process, placing it
> into given CGroup, etc.). And these functions all work over a
> single instance of device (virDomainVideoDef *, virDomainFSDef *,
> etc.), except for TPM handling code which takes virDomainDef *
> and iterates over it inside its module.
> 
> Remove this oddness and make qemuExtTPM*() functions look closer
> to the rest of the code.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_extdevice.c | 51 ++++++++++++++++------
>  src/qemu/qemu_tpm.c       | 89 +++++++++++----------------------------
>  src/qemu/qemu_tpm.h       | 11 +++--
>  3 files changed, 69 insertions(+), 82 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|