[PATCH] qemu_hotplug: Deny changing @rss and @rss_hash_report attributes of virtio vNICs

[Michal Prívozník]

On 5/23/22 18:29, Laine Stump wrote:
> On 5/23/22 11:22 AM, Michal Privoznik wrote:
>> We have virDomainUpdateDeviceFlags() API that allows changing of
>> some attributes of a device whilst domain is still running (e.g.
>> setting different QoS, link state change on vNICs). But only very
>> limited set of attributes can be changed and we have to check
>> whether user isn't trying to sneak in a change that's not
>> allowed. Well, in case of a virtio vNIC we forgot to check for
>> @rss and @rss_hash_report attributes of <driver/>.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2082540
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>   src/qemu/qemu_hotplug.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Laine Stump <laine at redhat.com>

Thanks pushed.

> 
> (too bad there's not an elegant automated way of pointing out when a new
> field is added that can't be updated at runtime)

Well, so far we have just ints to compare, so we could do memcmp() but
that won't work when a pointer is introduced into the struct. I thought
about another version of this patch that would switch to memcmp()
instead of adding two more comparisons, but realized the problem with
pointer.

Michal