[PATCH 05/17] virDomainStorageNetworkParseHost: Switch to virXMLPropEnumDefault()

Boris Fiuczynski fiuczy at linux.ibm.com
Tue May 24 15:19:01 UTC 2022


On 5/23/22 3:08 PM, Michal Privoznik wrote:
> The virDomainStorageNetworkParseHost() function uses old style of
> parsing XML (virXMLPropString + str2enum conversion). Use
> virXMLPropEnumDefault() which encapsulates those steps.
> 
> Signed-off-by: Michal Privoznik<mprivozn at redhat.com>
> ---
>   src/conf/domain_conf.c                        | 19 +++++++------------
>   src/conf/storage_source_conf.h                |  2 +-
>   src/qemu/qemu_backup.c                        |  2 +-
>   src/qemu/qemu_block.c                         |  2 +-
>   src/qemu/qemu_command.c                       |  2 ++
>   src/qemu/qemu_monitor_json.c                  |  2 +-
>   .../storage_file_backend_gluster.c            |  2 +-
>   .../storage_source_backingstore.c             | 16 ++++++++++------
>   8 files changed, 24 insertions(+), 23 deletions(-)


Besides what I commented in patch 4

Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



More information about the libvir-list mailing list