[PATCH 07/17] virDomainHostdevSubsysSCSIVHostDefParseXML: Switch to virXMLPropEnumDefault()

Boris Fiuczynski fiuczy at linux.ibm.com
Tue May 24 15:44:06 UTC 2022


On 5/23/22 3:08 PM, Michal Privoznik wrote:
> The virDomainHostdevSubsysSCSIVHostDefParseXML() function uses
> old style of parsing XML (virXMLPropString + str2enum
> conversion). Use virXMLPropEnumDefault() which encapsulates those
> steps.
> 
> Signed-off-by: Michal Privoznik<mprivozn at redhat.com>
> ---
>   src/conf/domain_conf.c | 19 +++++--------------
>   src/conf/domain_conf.h |  4 ++--
>   2 files changed, 7 insertions(+), 16 deletions(-)

Besides what I commented in patch 4

Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



More information about the libvir-list mailing list