[PATCH 12/17] virDomainChrDefParseXML: Switch to virXMLPropEnumDefault()

[Boris Fiuczynski]

On 5/23/22 3:08 PM, Michal Privoznik wrote:
> The virDomainChrDefParseXML() function uses old style of parsing
> XML (virXMLPropString + str2enum conversion). Use
> virXMLPropEnumDefault() which encapsulates those steps.

virXMLPropEnumDefault and virXMLPropEnum (above and in subject)

> 
> Signed-off-by: Michal Privoznik<mprivozn at redhat.com>
> ---
>   src/ch/ch_monitor.c              |  2 +-
>   src/conf/domain_conf.c           | 82 +++++++++++---------------------
>   src/conf/domain_conf.h           |  2 +-
>   src/conf/domain_validate.c       |  2 +-
>   src/conf/virchrdev.c             | 29 +++++++++++
>   src/libxl/libxl_conf.c           | 20 ++++++++
>   src/libxl/xen_common.c           | 23 ++++++++-
>   src/qemu/qemu_command.c          |  6 +--
>   src/qemu/qemu_domain.c           | 34 ++++++++++++-
>   src/qemu/qemu_monitor_json.c     |  2 +-
>   src/qemu/qemu_process.c          |  2 +-
>   src/qemu/qemu_validate.c         |  2 +-
>   src/security/security_apparmor.c |  4 +-
>   src/security/security_dac.c      |  4 +-
>   src/security/security_selinux.c  | 24 ++++++++++
>   src/vmx/vmx.c                    | 26 ++++++++++
>   tests/testutilsqemu.c            |  2 +-
>   17 files changed, 197 insertions(+), 69 deletions(-)

Besides above, the comment in the separate response and what I commented 
in patch 4

Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294