[PATCH 15/17] virDomainInputDefParseXML: Switch to virXMLPropEnumDefault()

Boris Fiuczynski fiuczy at linux.ibm.com
Tue May 24 17:33:32 UTC 2022


On 5/23/22 3:08 PM, Michal Privoznik wrote:
> The virDomainInputDefParseXML() function uses old style of
> parsing XML (virXMLPropString + str2enum conversion). Use
> virXMLPropEnumDefault() which encapsulates those steps.

virXMLPropEnum and virXMLPropEnumDefault

> 
> Signed-off-by: Michal Privoznik<mprivozn at redhat.com>
> ---
>   src/conf/domain_audit.c          |  2 +-
>   src/conf/domain_conf.c           | 86 +++++++++++++-------------------
>   src/conf/domain_conf.h           |  6 +--
>   src/conf/domain_validate.c       |  2 +-
>   src/libxl/libxl_conf.c           |  4 ++
>   src/libxl/xen_xl.c               |  3 ++
>   src/libxl/xen_xm.c               |  3 ++
>   src/qemu/qemu_cgroup.c           | 12 +++++
>   src/qemu/qemu_command.c          | 10 ++--
>   src/qemu/qemu_domain_address.c   |  4 +-
>   src/qemu/qemu_hotplug.c          |  4 +-
>   src/qemu/qemu_validate.c         |  4 +-
>   src/security/security_apparmor.c |  2 +-
>   src/security/security_dac.c      |  4 +-
>   src/security/security_selinux.c  |  4 +-
>   15 files changed, 80 insertions(+), 70 deletions(-)

Besides above and what I commented in patch 4

Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



More information about the libvir-list mailing list