[PATCH 2/3] cpu_ppc64: add support for host-model on POWER10

[Daniel Henrique Barboza]

On 5/24/22 10:47, Andrea Bolognani wrote:
> On Tue, May 24, 2022 at 10:02:41AM -0300, Daniel Henrique Barboza wrote:
>> +++ b/tests/qemuxml2argvdata/pseries-cpu-compat-power10.xml
>> +  <devices>
>> +      <emulator>/usr/bin/qemu-system-ppc64</emulator>
>> +      <console type='pty'>
>> +        <address type="spapr-vio"/>
>> +      </console>
> 
> spapr-vio is the default for pseries VMs, so you could have just
> 
>    <console type='pty'/>
> 
> here. Or remove the element altogether: this test case is about CPU
> compat modes after all, not serial consoles :)
> 
>> +++ b/tests/qemuxml2xmloutdata/pseries-cpu-compat-power10.ppc64-latest.xml
>> +  <devices>
>> +    <emulator>/usr/bin/qemu-system-ppc64</emulator>
>> +    <controller type='usb' index='0' model='pci-ohci'>
>> +      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/>
>> +    </controller>
> 
> You could add
> 
>    <controller type='usb' model='none'/>
> 
> to the input XML to prevent this from being generated.
> 
>> +++ b/tests/testutilsqemu.h
>>   virQEMUCaps *qemuTestParseCapabilitiesArch(virArch arch,
>>                                                const char *capsFile);
>> +
>>   virCPUDef *qemuTestGetCPUDef(qemuTestCPUDef d);
> 
> Spurious whitespace change. Please remove it before pushing.
> 
> 
> Regardless of whether or not you decide to minimize the input and
> output files according to the suggestions above,

I implemented all the suggestions before pushing. Thanks!


Daniel

> 
>    Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>