[PATCH] ci: Refresh generated files

Martin Kletzander mkletzan at redhat.com
Fri May 27 12:47:20 UTC 2022


On Fri, May 27, 2022 at 12:45:17PM +0100, Daniel P. Berrangé wrote:
>On Fri, May 27, 2022 at 01:37:10PM +0200, Martin Kletzander wrote:
>> Notable changes:
>>
>> * 'lcitool manifest' now generates absolute include paths
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>> Pushed under the 'build-breaker' and 'just-ci-update' rules (just in case the latter also exists).
>
>Unfortunately this change is not needed and won't fix the
>reported build problem. We need the .gitlab-ci.yml to
>add 'optional: true' to the 'needs:' in the failing jobs.
>

It took me a while to understand it, but what you're saying is that the
container jobs are not even defined if the dockerfiles are not changed
and hence the dependency cannot be resolved?  If that's it then good, if
not, then I'm baffled once again.

>>
>>  ci/gitlab.yml | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/ci/gitlab.yml b/ci/gitlab.yml
>> index 379a41111cab..cab4e6074c21 100644
>> --- a/ci/gitlab.yml
>> +++ b/ci/gitlab.yml
>> @@ -5,8 +5,8 @@
>>  # https://gitlab.com/libvirt/libvirt-ci
>>
>>  include:
>> -  - local: 'ci/gitlab/container-templates.yml'
>> -  - local: 'ci/gitlab/build-templates.yml'
>> -  - local: 'ci/gitlab/sanity-checks.yml'
>> -  - local: 'ci/gitlab/containers.yml'
>> -  - local: 'ci/gitlab/builds.yml'
>> +  - local: '/ci/gitlab/container-templates.yml'
>> +  - local: '/ci/gitlab/build-templates.yml'
>> +  - local: '/ci/gitlab/sanity-checks.yml'
>> +  - local: '/ci/gitlab/containers.yml'
>> +  - local: '/ci/gitlab/builds.yml'
>> --
>> 2.35.1
>>
>
>With regards,
>Daniel
>-- 
>|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
>|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
>|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220527/74b0fe8e/attachment.sig>


More information about the libvir-list mailing list