[PATCH 2/2] qemu_namespace: Make qemuDomainGetPreservedMounts() more robust wrt running VMs

[Ján Tomko]

On a Monday in 2022, Michal Privoznik wrote:
>The aim of qemuDomainGetPreservedMounts() is to get a list of
>filesystems mounted under /dev and optionally generate a path for
>each one where they are moved temporarily when building the
>namespace. And if given domain is also running it looks into its
>mount table rather than at the host one. But if it did look at
>the domain's private mount table, it find /dev mounted twice: the
>first time by udev, the second time the tmpfs mounted by us.
>
>Now, later in the function there's a "sorting" algorithm that
>tries to reduce number of mount points needing preservation, by
>identifying nested mount points. And if we keep the second
>occurrence of /dev on the list, well, after the "sorting" we are
>left with nothing but "/dev" because all other mount points are
>nested.
>
>Fixes: 46b03819ae8d833b11c2aaccb2c2a0361727f51b
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_namespace.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano