[PATCH 02/11] conf: domain: Remove pointless XML node name validation in virSysinfoBIOSParseXML

Peter Krempa pkrempa at redhat.com
Tue Nov 1 15:02:16 UTC 2022


The only caller passes 'node' argument originating from an XPath lookup
for the 'bios' element, so there's no point in checking it once more.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/domain_conf.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 15db12876e..eab2e98792 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -12140,12 +12140,6 @@ virSysinfoBIOSParseXML(xmlNodePtr node,

     ctxt->node = node;

-    if (!virXMLNodeNameEqual(node, "bios")) {
-        virReportError(VIR_ERR_XML_ERROR, "%s",
-                       _("XML does not contain expected 'bios' element"));
-        return -1;
-    }
-
     def->vendor = virXPathString("string(entry[@name='vendor'])", ctxt);
     def->version = virXPathString("string(entry[@name='version'])", ctxt);
     def->date = virXPathString("string(entry[@name='date'])", ctxt);
-- 
2.37.3



More information about the libvir-list mailing list