[libvirt PATCH v2 03/24] cpu: make x86 feature alias names machine readable

[Daniel P. Berrangé]

On Thu, Nov 03, 2022 at 04:21:34PM +0100, Tim Wiederhake wrote:
> On Mon, 2022-10-31 at 09:38 +0000, Daniel P. Berrangé wrote:
> > On Fri, Oct 28, 2022 at 05:06:34PM +0200, Tim Wiederhake wrote:
> > > Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
> > > Reviewed-by: Jiri Denemark <jdenemar at redhat.com>
> > > ---
> > >  src/cpu_map/x86_features.xml | 55 +++++++++++++++++++++++++-------
> > > ----
> > >  1 file changed, 38 insertions(+), 17 deletions(-)
> > > 
> > > diff --git a/src/cpu_map/x86_features.xml
> > > b/src/cpu_map/x86_features.xml
> > > index 4cf3ff0804..90d0f43fc6 100644
> > > --- a/src/cpu_map/x86_features.xml
> > > +++ b/src/cpu_map/x86_features.xml
> > > @@ -98,10 +98,12 @@
> > >    </feature>
> > >  
> > >    <!-- standard features, ECX -->
> > > -  <feature name='pni'> <!-- sse3 -->
> > > +  <feature name='pni'>
> > > +    <alias name='sse3'/>
> > 
> > IMHO, we should distinguish this as internal data via a NS to
> > re-inforce to our future selves that its only used when syncing
> > data from QEMU.
> > 
> >    <qemu:alias nmame="sse3"/>
> > 
> > And add xmlns:qemu="https://libvirt.org/cpufeature/qemu/1.0" on
> > the top level.
> > 
> I believe that using namespaces makes using this information in the
> sync script, and later in virQEMUCapsCPUFeatureTranslate, harder than
> strictly necessary. Would you be fine instead with a "source" or "type"
> attribute instead?
> 
>     <alias name='foo' source='qemu'/>
>     <alias name='bar' source='linux'/>
>     <alias name='baz' source='where-the-feature-is-called-this-way'/>

Yes, that could be ok, and makes it clear where the alias
came from.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|