[PATCH 07/12] schema: Introduce scaffolding for schema for <privateData> elements

[Peter Krempa]

On Mon, Nov 07, 2022 at 09:53:55 +0000, Daniel P. Berrangé wrote:
> On Tue, Nov 01, 2022 at 03:01:45PM +0100, Peter Krempa wrote:
> > Libvirt internally (e.g. in the status XML) stores additional data for
> > various objects described by the XML. The data is usually stored in
> > <privateData> or similar sub-elements.
> > 
> > This patch adds possibility for internal schema files to describe the
> > <privateData> elements by schema while still disallowing them for the
> > public schema.
> > 
> > This patch adds definitions for private data of <disk> and the
> > corresponding storage source of a disk.
> > 
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  src/conf/schemas/domaincommon.rng |  3 +++
> >  src/conf/schemas/privatedata.rng  | 30 ++++++++++++++++++++++++++++++
> >  2 files changed, 33 insertions(+)
> >  create mode 100644 src/conf/schemas/privatedata.rng
> 
> This addition seems to have broken the validation:
> 
> https://gitlab.com/libvirt/libvirt-python/-/jobs/3281787918
> 
> >           raise libvirtError('virDomainCheckpointCreateXML() failed')
> E           libvirt.libvirtError: internal error: Unable to parse RNG /builds/libvirt/libvirt-python/scratch/vroot/share/libvirt/schemas/domaincheckpoint.rng: xmlRelaxNG: could not load /builds/libvirt/libvirt-python/scratch/vroot/share/libvirt/schemas/privatedata.rng
> 
> Presumably we need to add privatedata.rng to meson.build too ?

Oops, yes. And probably also in the spec file in case when we don't
wildcard-include all schemas.