[PATCH 02/48] qemu: Acquire QUERY job in qemuDomainQueryWakeupSuspendSupport()

Michal Privoznik mprivozn at redhat.com
Tue Nov 8 08:29:04 UTC 2022


The qemuDomainQueryWakeupSuspendSupport() does not change state
of the domain as it just runs 'query-current-machine' QMP
command. Therefore, there's no need for it to acquire MODIFY job,
QUERY job is perfectly okay.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7c8fc8949c..56b809617a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -16323,7 +16323,7 @@ qemuDomainQueryWakeupSuspendSupport(virDomainObj *vm,
     if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_QUERY_CURRENT_MACHINE))
         return -1;
 
-    if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0)
+    if (virDomainObjBeginJob(vm, VIR_JOB_QUERY) < 0)
         return -1;
 
     if ((ret = virDomainObjCheckActive(vm)) < 0)
-- 
2.37.4



More information about the libvir-list mailing list