[PATCH 03/48] tests: Make qemuAgent single sync

Michal Prívozník mprivozn at redhat.com
Tue Nov 8 08:53:22 UTC 2022


On 11/8/22 09:44, Peter Krempa wrote:
> On Tue, Nov 08, 2022 at 09:29:05 +0100, Michal Privoznik wrote:
>> The qemuAgent has option to issue guest-sync command before each
>> intended command or issue the sync commend just once, right after
>> the socked is opened and before the first intended command is
>> issued. The latter is referred to as single sync agent and is
>> enabled by VSERPORT_CHANGED event which allows us to detect
>> when the agent (dis-)connects in the guest.
>>
>> Now, every QEMU that we support (4.2.0 or newer) has the event
>> and thus will use single sync agent. Therefore, adjust
>> qemuagenttest to make it test what's used in the real world,
>> rather than old approach.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>  tests/qemuagenttest.c        | 50 +++---------------------------------
>>  tests/qemumonitortestutils.c |  2 +-
>>  2 files changed, 4 insertions(+), 48 deletions(-)
> 
> The 'qemuagenttest' is broken after this commit:
> 
>  1) FSFreeze                                                          ...
> expected command 'guest-fsfreeze-freeze' got 'guest-sync'
> 

You have to fetch current master. It requires fix to a regression I've
merged just before sending these.

  qemu_agent: Bring back single sync

Michal



More information about the libvir-list mailing list