[PATCH 43/48] qemu: Assume QEMU_CAPS_DISK_SHARE_RW

Ján Tomko jtomko at redhat.com
Tue Nov 8 09:24:41 UTC 2022


On a Tuesday in 2022, Michal Privoznik wrote:
>Introduced in QEMU's commit of v2.9.0-rc0~48^2~25 the .share-rw
>attribute of virtio-blk device is always available for all QEMU
>versions we support (4.2.0, currently). Therefore, we can assume
>the capability is always set and thus doesn't need to be checked
>for.
>
>The change in controller-order.args is justified, because the
>qemuxml2argvdatatest runs the test case with very minimalistic
>set of capabilities, that's nowhere near real life scenario.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c                      | 3 +--
> tests/qemuxml2argvdata/controller-order.args | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano


More information about the libvir-list mailing list