[PATCH] qemu_tpm: Check for qemuTPMSetupEncryption() errors

[Ján Tomko]

On a Tuesday in 2022, Michal Privoznik wrote:
>Inside of qemuTPMEmulatorBuildCommand() there are two calls to
>qemuTPMSetupEncryption() which simply ignore returned error. This
>is suboptimal because then we rely on swtpm binary reporting a
>generic error (something among invalid arguments) while an error
>reported by qemuTPMSetupEncryption() is more specific.

It seems like qemuTPMSetupEncryption does not report an error in all
cases, specifically virCommandSetSendBuffer only sets an errno.

So in that case, "no error message" would be a downgrade from
"generic error message".

Jano

>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_tpm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20221122/79cf401e/attachment.sig>