[PATCH v2] cpu_s390: Implement getVendorForModel for IBM Z

Thomas Huth thuth at redhat.com
Fri Nov 25 10:35:08 UTC 2022


On 25/11/2022 11.29, Boris Fiuczynski wrote:
> On 11/25/22 10:36 AM, Thomas Huth wrote:
>> When running "virsh domcapabilities" on a s390x host, all the CPU
>> models show up with vendor='unknown' - which sounds kind of weird
>> since the vendor of these mainframe CPUs is well known: IBM.
>> All CPUs starting with either "z" or "gen" match a real mainframe
>> CPU by IBM, so let's return the string "IBM" for those now.
>> The only remaining ones are now the artifical "qemu" and "max"
> 
> s/artifical/artificial/
> 
>> models from QEMU itself, so it should be OK to get an "unknown"
>> vendor for those two.
>>
>> Thanks to Boris Fiuczynski for helping with the domaincapsdata!
> 
> Thanks for the thanks. :D
> Instead of the sentence you could remove the RB and add
> Signed-off-by: Boris Fiuczynski<fiuczy at linux.ibm.com>

OK, I'll send a v3 with both suggestions (by you and Jiri) addressed.

  Thomas




More information about the libvir-list mailing list