[PATCH 2/9] virCommandDoAsyncIO: Drop misleading statement about main event loop

Michal Privoznik mprivozn at redhat.com
Wed Nov 30 09:48:04 UTC 2022


Back in v1.0.3-rc1~235 when I was adding virCommandDoAsyncIO(),
the main event loop was used to poll() on the pipe to the child
process. But this was promptly changed to a separate thread
handling I/O in v1.0.3-rc1~127. However, the corresponding
comment to virCommandDoAsyncIO() still documents the original
state.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/vircommand.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index cdc74bc2fd..4f60432c0a 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -3078,8 +3078,6 @@ virCommandFree(virCommand *cmd)
  *
  *      ...
  *
- *
- * The libvirt's event loop is used for handling stdios of @cmd.
  * Since current implementation uses strlen to determine length
  * of data to be written to @cmd's stdin, don't pass any binary
  * data. If you want to re-run command, you need to call this and
-- 
2.37.4



More information about the libvir-list mailing list