[libvirt PATCH] qemu: Pass vm to qemuMigrationCookieParse if it exists

Michal Prívozník mprivozn at redhat.com
Wed Nov 30 15:42:14 UTC 2022


On 11/30/22 15:24, Jiri Denemark wrote:
> The vm object is used inside qemuMigrationCookieParse based on the flags
> passed to qemuMigrationCookieParse and the content of the cookie. The
> callers should not just blindly guess and pass NULL if they
> (incorrectly) think the vm object is not needed. We should always pass
> the vm object unless it does not exist yet.
> 
> This fixes a bug when statistics of a completed migration reported
> "Unknown" operation instead of "Incoming migration" on the destination
> host.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2137298
> 
> Fixes: v8.7.0-79-g0150f7a8c1
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal



More information about the libvir-list mailing list