[PATCH] node_device_conf: Avoid memleak in virNodeDeviceGetPCIVPDDynamicCap()

Peter Krempa pkrempa at redhat.com
Wed Nov 30 16:21:22 UTC 2022


On Wed, Nov 30, 2022 at 16:25:05 +0100, Michal Privoznik wrote:
> The virNodeDeviceGetPCIVPDDynamicCap() function is called from
> virNodeDeviceGetPCIDynamicCaps() and therefore has to be a wee
> bit more clever about adding VPD capability. Namely, it has to
> remove the old one before adding a new one. This is how other
> functions called from virNodeDeviceGetPCIDynamicCaps() behave
> as well.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2143235
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/node_device_conf.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list