[PATCH 01/43] util: xml: Expose all arguments of virXMLParseHelper in virXMLParse macro

Ján Tomko jtomko at redhat.com
Tue Oct 4 15:23:28 UTC 2022


On a Tuesday in 2022, Peter Krempa wrote:
>The generic helper also has helper code to validate the root element and
>create an XPath context. Many places in the code duplicate code for
>doing these operations.
>
>Extend the helper to provide all arguments and fix all callers.
>
>In many cases this patch refactores the passing of the 'validate'

*refactors

>field into a separate variable to avoid quirky looking arguments.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/backup_conf.c           | 5 +++--
> src/conf/checkpoint_conf.c       | 2 +-
> src/conf/domain_conf.c           | 6 ++++--
> src/conf/interface_conf.c        | 3 ++-
> src/conf/network_conf.c          | 2 +-
> src/conf/node_device_conf.c      | 3 ++-
> src/conf/nwfilter_conf.c         | 5 +++--
> src/conf/secret_conf.c           | 5 +++--
> src/conf/snapshot_conf.c         | 5 +++--
> src/conf/storage_conf.c          | 6 ++++--
> src/conf/virnetworkportdef.c     | 4 ++--
> src/conf/virnwfilterbindingdef.c | 4 ++--
> src/conf/virnwfilterbindingobj.c | 3 ++-
> src/test/test_driver.c           | 2 +-
> src/util/virxml.h                | 8 ++++++--
> src/vbox/vbox_snapshot_conf.c    | 6 +++---
> src/vz/vz_sdk.c                  | 3 ++-
> tests/qemuxml2argvtest.c         | 3 ++-
> 18 files changed, 46 insertions(+), 29 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano


More information about the libvir-list mailing list