[PATCH] nodedev: ignore EINVAL from libudev in udevEventHandleThread

[Christian Ehrhardt]

On Thu, Oct 13, 2022 at 10:06 AM Erik Skultety <eskultet at redhat.com> wrote:
>
> On Thu, Oct 13, 2022 at 08:05:41AM +0200, christian.ehrhardt at canonical.com wrote:
> > From: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> >
> > Certiain udev entries might be of a size that makes libudev emit EINVAL
> > which right now leads to udevEventHandleThread exiting. Due to no more
> > handling events other elements of libvirt will start pushing for events
> > to be consumed which never happens causing a busy loop burning a cpu
> > without any gain.
> >
> > After evaluation of the root cause of the example case discussed in
> > in #245 and a test run ignoring EINVAL it was considered safe to add
> > EINVAL to the ignored errnos to not exit udevEventHandleThread giving
> > it more resilience.
> >
> > Fixes: #245
>
> Please always use full URLs instead of number references to have clickable
> links from running git history in a terminal.

Sure, done
Sent a v2 with the reviewed-by and the fix as URL

I also did file a systemd issue and referenced it from our issue.

*sigh*
and now also a v3 as I saw a typo too late

> Regards,
> Erik
>


-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd