[PATCH 4/5] qemu: Refresh state after restore from a save image

Michal Privoznik mprivozn at redhat.com
Tue Oct 18 08:57:48 UTC 2022

When restoring a domain from a save image, we need to query QEMU
for some runtime information that is not stored in status XML, or
even if it is, it's not parsed (e.g. virtio-mem actual size, or
soon rx-filters for macvtaps).

During migration, this is done in qemuMigrationDstFinishFresh(),
or in case of newly started domain in qemuProcessStart(). Except,
the way that the code is written, when restoring from a save
image (which is effectively a migration), the state is never
refreshed, because qemuProcessStart() sees incoming migration so
it does not refresh the state thinking it'll be done in the
finish phase. But restoring from a save image has no finish
phase. Therefore, refresh the state explicitly after the domain
was restored but before vCPUs are resumed.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
 src/qemu/qemu_saveimage.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index 79567bf17d..ef62303728 100644
--- a/src/qemu/qemu_saveimage.c
+++ b/src/qemu/qemu_saveimage.c
@@ -672,6 +672,8 @@ qemuSaveImageStartVM(virConnectPtr conn,
     virObjectEventStateQueue(driver->domainEventState, event);
+    if (qemuProcessRefreshState(driver, vm, asyncJob) < 0)
+        goto cleanup;
     /* If it was running before, resume it now unless caller requested pause. */
     if (header->was_running && !start_paused) {

More information about the libvir-list mailing list