[PATCH] qemuxml2argvtest: Don't re-parse and re-generate commandline for QAPI schema validation

Erik Skultety eskultet at redhat.com
Thu Oct 20 05:34:37 UTC 2022


On Wed, Oct 19, 2022 at 05:28:19PM +0200, Peter Krempa wrote:
> The removal of the special internal flag for '-netdev' validatition now
> allows us to use the same virCommand object for validation of the
> schema.
> 
> Pass it into the validator instead of re-parsing and re-generating
> everything.
> 
> This improved the runtime of qemuxml2argvtest by ~25% on my box.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
Lovely.

Reviewed-by: Erik Skultety <eskultet at redhat.com>



More information about the libvir-list mailing list