[PATCH 0/6] Implement XML validation feature for node devices and storage volumes

Jonathon Jongsma jjongsma at redhat.com
Fri Oct 21 15:03:51 UTC 2022


On 10/20/22 9:37 AM, Peter Krempa wrote:
> In the last round of adding support for built-in validation the node
> device APIs and storage volume creation were not covered.
> 
> Note that due to the close freeze date I've already marked the APIs for
> v8.10.
> 
> Peter Krempa (6):
>    conf: node_device: Add 'validate' argument to virNodeDeviceDefParse
>    nodedev: Add VIR_NODE_DEVICE_(CREATE|DEFINE)_XML_VALIDATE flags
>    nodedev|test: Implement support for validating node device XMLs
>    conf: storage: Add support for validating storage vol XML to
>      virStorageVolDefParse
>    storage: Add VIR_STORAGE_VOL_CREATE_VALIDATE flag
>    storage|test|vbox: Implement support for validating storage volume
>      XMLs
> 
>   docs/manpages/virsh.rst              | 19 +++++++++++++++----
>   include/libvirt/libvirt-nodedev.h    | 19 +++++++++++++++++++
>   include/libvirt/libvirt-storage.h    |  1 +
>   src/conf/node_device_conf.c          |  5 +++--
>   src/conf/node_device_conf.h          |  3 ++-
>   src/conf/storage_conf.c              |  3 ++-
>   src/conf/storage_conf.h              |  2 ++
>   src/hypervisor/domain_driver.c       |  6 +++---
>   src/libvirt-nodedev.c                |  4 ++--
>   src/node_device/node_device_driver.c | 10 ++++++----
>   src/storage/storage_driver.c         | 18 ++++++++++++++----
>   src/test/test_driver.c               | 24 +++++++++++++++++-------
>   src/vbox/vbox_storage.c              |  8 ++++++--
>   tests/nodedevmdevctltest.c           |  4 ++--
>   tests/nodedevxml2xmltest.c           |  3 ++-
>   tools/virsh-nodedev.c                | 20 ++++++++++++++++++--
>   tools/virsh-volume.c                 | 14 ++++++++++++++
>   17 files changed, 128 insertions(+), 35 deletions(-)
> 


Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>



More information about the libvir-list mailing list