[PATCH 08/43] virNodeDeviceCapPCIDefFormat: Use %u for unsigned values

Peter Krempa pkrempa at redhat.com
Mon Oct 24 14:14:13 UTC 2022


'bus', 'slot' and 'function' are unsigned int variables parsed as
unsigned int, but were formated as signed.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/node_device_conf.c                              | 6 +++---
 tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 9c0a27b9f0..b079c3713d 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -323,10 +323,10 @@ virNodeDeviceCapPCIDefFormat(virBuffer *buf,
         virBufferAsprintf(buf, "<class>0x%.6x</class>\n", data->pci_dev.klass);
     virBufferAsprintf(buf, "<domain>%d</domain>\n",
                       data->pci_dev.domain);
-    virBufferAsprintf(buf, "<bus>%d</bus>\n", data->pci_dev.bus);
-    virBufferAsprintf(buf, "<slot>%d</slot>\n",
+    virBufferAsprintf(buf, "<bus>%u</bus>\n", data->pci_dev.bus);
+    virBufferAsprintf(buf, "<slot>%u</slot>\n",
                       data->pci_dev.slot);
-    virBufferAsprintf(buf, "<function>%d</function>\n",
+    virBufferAsprintf(buf, "<function>%u</function>\n",
                       data->pci_dev.function);
     virBufferAsprintf(buf, "<product id='0x%04x'",
                       data->pci_dev.product);
diff --git a/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml b/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
index 387fce7051..df620dc64f 100644
--- a/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
+++ b/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
@@ -4,7 +4,7 @@
   <capability type='pci'>
     <class>0xffffff</class>
     <domain>0</domain>
-    <bus>0</bus>
+    <bus>4294967295</bus>
     <slot>2</slot>
     <function>0</function>
     <product id='0x0416'>4th Gen Core Processor Integrated Graphics Controller</product>
-- 
2.37.3



More information about the libvir-list mailing list