[PATCH 09/43] conf: Always use 'string()' conversion with virXPath(U)LongLong

Ján Tomko jtomko at redhat.com
Mon Oct 24 14:48:45 UTC 2022


On a Monday in 2022, Peter Krempa wrote:
>When the 'string()' conversion is used the number is parsed inside
>libvirt by our internal helpers which work on integers in contrast to
>when 'number()' is used and libxml2 uses a 'double' variable internally.
>
>On the upper extremes of the 64 bit variables the doulbe precision

*double

>variable doesn't have enough precision to represent each distinct
>integer and thus could cause problems.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_conf.c      | 6 +++---
> src/conf/node_device_conf.c | 4 ++--
> src/conf/storage_conf.c     | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano


More information about the libvir-list mailing list