[libvirt PATCH v2] Revert "cgroup/LXC: Do not condition availability of v2 by controllers"

Michal Prívozník mprivozn at redhat.com
Tue Oct 25 11:46:22 UTC 2022


On 10/25/22 13:43, Pavel Hrdina wrote:
> This reverts commit e49313b54ed2a149c71f9073659222742ff3ffb0.
> This reverts commit a0f37232b9c4296ca16955cc625f75eb848ace39.
> 
> Revert them together to not break build.
> 
> This fix of the issue is incorrect and breaks usage of other controllers
> in hybrid mode that systemd creates, specifically usage of devices and
> cpuacct controllers as they are now assumed to be part of the cgroup v2
> topology which is not true.
> 
> We need to find different solution to the issue.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/util/vircgroup.c   |  6 ++----
>  src/util/vircgroupv2.c | 15 +++++++++++++++
>  2 files changed, 17 insertions(+), 4 deletions(-)


Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

This brings me back to my original proposal - let's forget that hybrid
mode exist and aim on v1 or v2, solely.

Michal



More information about the libvir-list mailing list