[libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

Peter Krempa pkrempa at redhat.com
Thu Sep 1 13:43:58 UTC 2022


On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_snapshot.c | 94 ++++++++++++++++++++++------------------
>  1 file changed, 53 insertions(+), 41 deletions(-)

Code change looks reasonable. I'd probably go for a C99-style init of
the 'rem' struct.

Please provide a commit message and function header documentation
outlining what it's supposed to do.


More information about the libvir-list mailing list