[PATCH] Revert "conf: clean up memory containing secrets before freeing"

Ján Tomko jtomko at redhat.com
Wed Sep 7 13:00:27 UTC 2022


On a Wednesday in 2022, Peter Krempa wrote:
>Adding supposedly secure cleanup for secrets in anything related to the
>XML parser is pointless because there are multiple other un-sanitized
>copies of the full XML and the XML parser state at the very least.
>
>Similarly in case RPC was used to transport the XML the RPC buffers are
>not sanitized.
>
>Additionally this patch was incomplete as it didn't sanitize the the

d/the /

>password in the cleanup function for virDomainGraphicsAuthDef.
>
>This reverts commit 51f8130d78fde3201b49c02b7095ff918b6e658a.

Please drop the trailing period.

>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_conf.c | 2 --
> 1 file changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano


More information about the libvir-list mailing list