[PATCH v2 0/9] ix double free in URI alias lookup and fix misleading error with libvirtd

[Ján Tomko]

On a Friday in 2022, Peter Krempa wrote:
>When libvirtd is built without a driver we report a terrible error
>message which doesn't really point to what's happening.
>
>v2:
>  - propagate that we want to avoid the remote driver internally rather
>    than via a public API flag
>
>Peter Krempa (9):
>  virConnectOpenInternal: Avoid double free() when alias is an invalid
>    URI
>  virConnectOpenInternal: Switch to automatic memory cleanup
>  virConnectOpenInternal: Remove 'failed' label
>  remote: remoteOpenConn: Use virConnectOpenAuth instead of
>    virConnectOpen(ReadOnly)
>  remoteConnectOpen: Refactor cleanup
>  remote: doRemoteOpen: Automatically clean up 'priv'
>  lxc: Remove unneeded forward declaration of 'lxcStateInitialize'
>  virStateInitialize: Propagate whether running in monolithic daemon
>    mode to stateful driver init
>  remote: Don't attempt remote connection from libvirtd
>
> src/bhyve/bhyve_driver.c                |  1 +
> src/ch/ch_driver.c                      |  1 +
> src/driver-state.h                      |  1 +
> src/interface/interface_backend_netcf.c |  1 +
> src/interface/interface_backend_udev.c  |  1 +
> src/libvirt.c                           | 67 +++++++++++--------------
> src/libvirt_internal.h                  |  1 +
> src/libxl/libxl_driver.c                |  1 +
> src/lxc/lxc_driver.c                    |  5 +-
> src/network/bridge_driver.c             |  1 +
> src/node_device/node_device_udev.c      |  1 +
> src/nwfilter/nwfilter_driver.c          |  1 +
> src/qemu/qemu_driver.c                  |  1 +
> src/remote/remote_daemon.c              |  6 +++
> src/remote/remote_daemon_dispatch.c     |  7 ++-
> src/remote/remote_driver.c              | 59 +++++++++++-----------
> src/secret/secret_driver.c              |  1 +
> src/storage/storage_driver.c            |  1 +
> src/vz/vz_driver.c                      |  1 +
> 19 files changed, 83 insertions(+), 75 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano