[PATCH] meson: Require libssh-0.8.0 or newer

Ján Tomko jtomko at redhat.com
Wed Sep 14 15:14:24 UTC 2022


On a Wednesday in 2022, Michal Privoznik wrote:
>According to repology.org:
>
>              RHEL-8: 0.9.4
>              RHEL-9: 0.9.6
>           Debian 11: 0.9.5
>  openSUSE Leap 15.3: 0.8.7
>        Ubuntu 20.04: 0.9.3
>
>And the rest of distros has something newer anyways. Requiring
>0.8.0 or newer allows us to drop the terrible hack where we
>rename functions at meson level using #define.  Note, 0.8.0 is
>the version of libssh where the rename happened.
>

If we require 0.8.1, we can also ditch SHA1 usage:

#if LIBSSH_VERSION_INT < SSH_VERSION_INT(0, 8, 1)
# define VIR_SSH_HOSTKEY_HASH SSH_PUBLICKEY_HASH_SHA1
#else
# define VIR_SSH_HOSTKEY_HASH SSH_PUBLICKEY_HASH_SHA256
#endif

Jano

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> libvirt.spec.in |  2 +-
> meson.build     | 15 +--------------
> 2 files changed, 2 insertions(+), 15 deletions(-)


More information about the libvir-list mailing list