[PATCH] libvirt-guests: Fix dependency ordering in service file

[Michal Prívozník]

On 8/30/22 08:43, Martin Kletzander wrote:
> After some debugging and discussion with systemd team it turns out we
> are misusing the ordering in libvirt-guests.service.  That happened
> because we want to support both monolithic and modular daemon setups and
> on top of that we also want to support socket activation and services
> without socket activation.  Unfortunately this is impossible to express
> in the unit file because of how transactions are handled in systemd when
> dependencies are resolved and multiple actions (jobs) are queued.  For
> explanation from Michal Sekletar see comment #7 in the BZ this patch is
> fixing:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1964855#c7
> 
> In order to support all the scenarios this patch also amends the
> manpages so that users that are changing the default can also read how
> to correct the dependency ordering in libvirt-guests unit file.
> 
> Ideally we would also keep the existing configuration during upgrade,
> but due to our huge support matrix this seems hardly feasible as it
> could introduce even more problems.
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  docs/manpages/libvirtd.rst      | 14 ++++++++++++++
>  docs/manpages/virtlxcd.rst      | 14 ++++++++++++++
>  docs/manpages/virtqemud.rst     | 14 ++++++++++++++
>  docs/manpages/virtvboxd.rst     | 14 ++++++++++++++
>  docs/manpages/virtvzd.rst       | 14 ++++++++++++++
>  docs/manpages/virtxend.rst      | 14 ++++++++++++++
>  tools/libvirt-guests.service.in |  6 ------
>  7 files changed, 84 insertions(+), 6 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal