[libvirt] [PATCH v2] qemu: Remove host-passthrough validation check for host-phys-bits=on

Michal Prívozník mprivozn at redhat.com
Thu Sep 29 14:36:49 UTC 2022


On 9/28/22 19:07, Jim Fehlig wrote:
> On 9/8/22 01:07, Lin Ma wrote:
>> Besides the -cpu host, The host-phys-bits=on applies to custom or max
>> cpu model, So the host-passthrough validation check is unnecessary for
>> maxphysaddr with mode='passthrough'.
>>
>> Signed-off-by: Lin Ma <lma at suse.com>
>> ---
>>   src/qemu/qemu_validate.c                      |  7 -------
>>   .../cpu-phys-bits-passthrough2.err            |  2 +-
>>   .../cpu-phys-bits-passthrough2.xml            |  4 ++--
>>   .../cpu-phys-bits-passthrough3.err            |  1 -
>>   .../cpu-phys-bits-passthrough3.xml            | 20 -------------------
>>   tests/qemuxml2argvtest.c                      |  1 -
>>   6 files changed, 3 insertions(+), 32 deletions(-)
>>   delete mode 100644
>> tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.err
>>   delete mode 100644
>> tests/qemuxml2argvdata/cpu-phys-bits-passthrough3.xml
> 
> Hi Lin,
> 
> Reviewed-by: Jim Fehlig <jfehlig at suse.com>
> 
> Sorry for the delay. I forgot to review your patch before taking some
> days off, which is unfortunate since it would be nice to have in the
> 8.8.0 release. Perhaps Jiri will allow an exception.
> 
> @Jiri, would it be ok to push this patch for 8.8.0? It's boarder-line
> bug fix and fine to push after the release if you prefer.

Though I'm not Jiri, I think it's okay. It is a bugfix in my book.

Michal



More information about the libvir-list mailing list