[PATCH v2 01/10] make one-insn-per-tb an accel option

Richard Henderson richard.henderson at linaro.org
Mon Apr 3 18:23:48 UTC 2023


On 4/3/23 07:46, Peter Maydell wrote:
> This commit adds 'one-insn-per-tb' as a property on the TCG
> accelerator object, so you can enable it with
>     -accel tcg,one-insn-per-tb=on
> 
> It has the same behaviour as the existing '-singlestep' command line
> option.  We use a different name because 'singlestep' has always been
> a confusing choice, because it doesn't have anything to do with
> single-stepping the CPU.  What it does do is force TCG emulation to
> put one guest instruction in each TB, which can be useful in some
> situations (such as analysing debug logs).
> 
> The existing '-singlestep' commandline options are decoupled from the
> global 'singlestep' variable and instead now are syntactic sugar for
> setting the accel property.  (These can then go away after a
> deprecation period.)
> 
> The global variable remains for the moment as:
>   * what the TCG code looks at to change its behaviour
>   * what HMP and QMP use to query and set the behaviour
> 
> In the following commits we'll clean those up to not directly
> look at the global variable.
> 
> Signed-off-by: Peter Maydell<peter.maydell at linaro.org>
> ---
>   accel/tcg/tcg-all.c | 21 +++++++++++++++++++++
>   bsd-user/main.c     |  8 ++++++--
>   linux-user/main.c   |  8 ++++++--
>   softmmu/vl.c        | 17 +++++++++++++++--
>   qemu-options.hx     |  7 +++++++
>   5 files changed, 55 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson at linaro.org>

r~



More information about the libvir-list mailing list