Improve default machine type selection

[Peter Krempa]

On Thu, Apr 06, 2023 at 09:32:28 +0200, Peter Krempa wrote:
> On Wed, Apr 05, 2023 at 15:19:07 -0600, Jim Fehlig wrote:
> > On 3/16/23 11:56, Jim Fehlig wrote:

[...]

> > error: Failed to create domain from test.xml
> > error: internal error: process exited while connecting to monitor:
> > 2023-04-05T20:36:19.564896Z qemu-system-aarch64: Property
> > 'integratorcp-machine.acpi' not found
> 
> This is a known issue which should be already fixed if you use the
> upcoming qemu version.
> 
> Historically ACPI was controled via '-no-acpi' which is issued when you
> don't use the '<acpi/>' feature element in the definition. Also
> historically it was only used on x86. With development of the 'virt'
> machine type for arm which does use acpi this was un-carefully extended
> to aarch64 as well where it didn't work with non-virt machines.
> 
> Now with the latest qemu which reports which machine type actually
> support ACPI we avoid use of '-no-acpi' for those which don't support
> it.
> 
> Unfortunately the workaround of adding <acpi/> element to definition for
> a machine which doesn't have it doesn't work either, because a further
> validation check forces you to configure uefi if you want acpi.

This was also reported as an issue upstream:

https://gitlab.com/libvirt/libvirt/-/issues/297