[PATCH 0/5] qemu: Fix chardev hotplug and deny <console/> live detach

Michal Privoznik mprivozn at redhat.com
Wed Apr 12 14:25:05 UTC 2023


While trying to make live detach of <console/> work, I've accumulated
couple of patches. The most reasonable ones made it into this patch set
as paches 1-4. And after nearly losing my sanity, I've decided it's not
worth supporting live detach of <console/> since <serial/> works just
fine. And that's what patch 5 does. If somebody thinks it's too harsh,
I'm more than happy to review their patches that fix the problem.

What problem? Well, for starters:

https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c4
https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c8

Michal Prívozník (5):
  qemuDomainChrInsertPreAlloced: Fix adding implicit console
  qemuDomainChrRemove: Don't leak vmdef->consoles[0]
  qemuAssignDeviceChrAlias: Fix a crasher during <console/> hotplug
  qemuDomainRemoveChrDevice: Deal with qemuDomainChrRemove() failure
  qemu_hotplug: Deny live detach of <console/>

 src/qemu/qemu_alias.c   |  1 +
 src/qemu/qemu_hotplug.c | 43 +++++++++++++++++++++++++++++------------
 2 files changed, 32 insertions(+), 12 deletions(-)

-- 
2.39.2



More information about the libvir-list mailing list