[PATCH 2/3] qemu: Use configured iothread poll parameters on startup

Martin Kletzander mkletzan at redhat.com
Fri Apr 14 13:59:48 UTC 2023


On Fri, Mar 31, 2023 at 02:00:33PM +0200, Peter Krempa wrote:
>Implement the support for the persisted poll parameters and remove
>restrictions on saving config when modifying them during runtime.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c                       | 18 +++++++++++
> src/qemu/qemu_driver.c                        | 30 ++++++++++---------
> ...othreads-ids-pool-sizes.x86_64-latest.args |  6 ++--
> 3 files changed, 37 insertions(+), 17 deletions(-)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index 7e75354902..0693369faa 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -7300,6 +7300,24 @@ qemuBuildIOThreadCommandLine(virCommand *cmd,
>                                          NULL) < 0)
>             return -1;
>
>+        if (iothread->set_poll_max_ns &&
>+            virJSONValueObjectAdd(&props,
>+                                  "U:poll-max-ns", iothread->poll_max_ns,
>+                                  NULL) < 0)
>+            return -1;
>+
>+        if (iothread->set_poll_grow &&
>+            virJSONValueObjectAdd(&props,
>+                                  "u:poll-grow", iothread->poll_grow,
>+                                  NULL) < 0)
>+            return -1;
>+
>+        if (iothread->set_poll_shrink &&
>+            virJSONValueObjectAdd(&props,
>+                                  "U:poll-shrink", iothread->poll_shrink,

This is defined as int, but passed as long here, but if you are going to
make all of them switch to unsigned long long, then poll-grow above
needs a fix the other way around.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230414/2021e163/attachment.sig>


More information about the libvir-list mailing list