[PATCH 3/3] networkRefreshDhcpDaemon: Get dnsmasq's PID once

Michal Privoznik mprivozn at redhat.com
Mon Apr 17 12:09:03 UTC 2023


This is a relict of v3.7.0-rc1~132 when getter/setter APIs for
dnsmasq's PID were introduced. Previously, obj->dnsmasqPid was
accessed directly. But the aforementioned commit introduced two
calls to virNetworkObjGetDnsmasqPid() even though the result of
the first call is stored in a variable.

Remove the second call as it's unnecessary.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/network/bridge_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 7f2298a15e..9eb543a0a3 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -1599,7 +1599,6 @@ networkRefreshDhcpDaemon(virNetworkDriverState *driver,
     if (dnsmasqSave(dctx) < 0)
         return -1;
 
-    dnsmasqPid = virNetworkObjGetDnsmasqPid(obj);
     return kill(dnsmasqPid, SIGHUP);
 
 }
-- 
2.39.2



More information about the libvir-list mailing list