[PATCH v3 22/25] qemu: Store all iothread's 'poll*' attributes as unsigned long long

Ján Tomko jtomko at redhat.com
Wed Apr 19 14:02:06 UTC 2023


On a Wednesday in 2023, Peter Krempa wrote:
>Convert the internal types to unsigned long long. Luckily we can also
>covert the external types too:
>
> - 'qemuDomainSetIOThreadParams' can accept both _UINT and _ULLONG by
>   converting to 'virTypedParamsGetUnsigned'
>
> - querying is handled via the bulk stats API which is flexible:
>    - we use virTypedParamListAddUnsigned to use the bigger type only if
>      necessary
>    - most users don't even notice because the bindings abstract the
>      data types
>
>Apart from the code modifications we also improve the documenataion

*documentation

>which was missing for the setters.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> include/libvirt/libvirt-domain.h |  4 +++-
> src/libvirt-domain.c             | 14 +++++++----
> src/qemu/qemu_driver.c           | 28 +++++++++++-----------
> src/qemu/qemu_monitor.h          |  4 ++--
> src/qemu/qemu_monitor_json.c     | 41 ++++++++++++++++++++------------
> 5 files changed, 54 insertions(+), 37 deletions(-)
>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230419/8c9b5dde/attachment.sig>


More information about the libvir-list mailing list