[PATCH 08/11] qemuhotplugtest: Fix misleading comment on monitor unlock

Kristina Hanicova khanicov at redhat.com
Fri Apr 21 14:55:11 UTC 2023


On Fri, Apr 21, 2023 at 10:25 AM Michal Privoznik <mprivozn at redhat.com>
wrote:

> There's a comment in testQemuHotplug() trying to explain why we
> need to unlock the monitor object. Well, while it might have been
> correct when being introduced, it's no long factually correct as
>
*no longer

> just any function (attach/detach/update) might talk to the
> monitor and it expects the monitor to be unlocked (as it calls
> qemuDomainObjEnterMonitor() + qemuDomainObjExitMonitor()).
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemuhotplugtest.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> Reviewed-by: Kristina Hanicova <khanicov at redhat.com>

Kristina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230421/7e73cbf7/attachment.htm>


More information about the libvir-list mailing list