[PATCH v2 9/9] qemu: Stop virQEMUCaps propagation into qemuHostdevPreparePCIDevices()

Michal Privoznik mprivozn at redhat.com
Mon Apr 24 10:41:48 UTC 2023


After previous cleanups, qemuHostdevPreparePCIDevices() no longer
needs virQEMUCaps. Drop its passing from callers.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_hostdev.c | 5 +----
 src/qemu/qemu_hostdev.h | 2 --
 src/qemu/qemu_hotplug.c | 4 ++--
 src/qemu/qemu_process.c | 3 +--
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index 49347019ea..f329442f8c 100644
--- a/src/qemu/qemu_hostdev.c
+++ b/src/qemu/qemu_hostdev.c
@@ -181,7 +181,6 @@ qemuHostdevPreparePCIDevices(virQEMUDriver *driver,
                              const unsigned char *uuid,
                              virDomainHostdevDef **hostdevs,
                              int nhostdevs,
-                             virQEMUCaps *qemuCaps G_GNUC_UNUSED,
                              unsigned int flags)
 {
     return virHostdevPreparePCIDevices(driver->hostdevMgr,
@@ -261,7 +260,6 @@ qemuHostdevPrepareMediatedDevices(virQEMUDriver *driver,
 int
 qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
                                 virDomainDef *def,
-                                virQEMUCaps *qemuCaps,
                                 unsigned int flags)
 {
     if (!def->nhostdevs && !def->ndisks)
@@ -271,8 +269,7 @@ qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
         return -1;
 
     if (qemuHostdevPreparePCIDevices(driver, def->name, def->uuid,
-                                     def->hostdevs, def->nhostdevs,
-                                     qemuCaps, flags) < 0)
+                                     def->hostdevs, def->nhostdevs, flags) < 0)
         return -1;
 
     if (qemuHostdevPrepareUSBDevices(driver, def->name,
diff --git a/src/qemu/qemu_hostdev.h b/src/qemu/qemu_hostdev.h
index 2d484db878..3e9adc57a9 100644
--- a/src/qemu/qemu_hostdev.h
+++ b/src/qemu/qemu_hostdev.h
@@ -52,7 +52,6 @@ int qemuHostdevPreparePCIDevices(virQEMUDriver *driver,
                                  const unsigned char *uuid,
                                  virDomainHostdevDef **hostdevs,
                                  int nhostdevs,
-                                 virQEMUCaps *qemuCaps,
                                  unsigned int flags);
 int qemuHostdevPrepareUSBDevices(virQEMUDriver *driver,
                                  const char *name,
@@ -73,7 +72,6 @@ int qemuHostdevPrepareMediatedDevices(virQEMUDriver *driver,
                                       int nhostdevs);
 int qemuHostdevPrepareDomainDevices(virQEMUDriver *driver,
                                     virDomainDef *def,
-                                    virQEMUCaps *qemuCaps,
                                     unsigned int flags);
 
 void qemuHostdevReAttachOneNVMeDisk(virQEMUDriver *driver,
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index bf9d16e82b..b8b0a107aa 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1473,8 +1473,8 @@ qemuDomainAttachHostPCIDevice(virQEMUDriver *driver,
 
     if (!cfg->relaxedACS)
         flags |= VIR_HOSTDEV_STRICT_ACS_CHECK;
-    if (qemuHostdevPreparePCIDevices(driver, vm->def->name, vm->def->uuid,
-                                     &hostdev, 1, priv->qemuCaps, flags) < 0)
+    if (qemuHostdevPreparePCIDevices(driver, vm->def->name,
+                                     vm->def->uuid, &hostdev, 1, flags) < 0)
         return -1;
 
     if (qemuDomainAdjustMaxMemLockHostdev(vm, hostdev) < 0)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 75a1d88cd7..8d7fd28e37 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7164,8 +7164,7 @@ qemuProcessPrepareHost(virQEMUDriver *driver,
         hostdev_flags |= VIR_HOSTDEV_STRICT_ACS_CHECK;
     if (flags & VIR_QEMU_PROCESS_START_NEW)
         hostdev_flags |= VIR_HOSTDEV_COLD_BOOT;
-    if (qemuHostdevPrepareDomainDevices(driver, vm->def, priv->qemuCaps,
-                                        hostdev_flags) < 0)
+    if (qemuHostdevPrepareDomainDevices(driver, vm->def, hostdev_flags) < 0)
         return -1;
 
     VIR_DEBUG("Preparing chr device backends");
-- 
2.39.2



More information about the libvir-list mailing list