[PATCH] daemon: Treat logging of VIR_ERR_MULTIPLE_INTERFACES same as VIR_ERR_NO_INTERFACE

Martin Kletzander mkletzan at redhat.com
Wed Aug 2 12:38:09 UTC 2023


On Wed, Aug 02, 2023 at 10:11:24AM +0200, Peter Krempa wrote:
>When a query for an interface via virInterfaceLookupByMACString finds
>multiple interfaces an error is returned. Treat such error with the same
>'debug' priority as we treat when the interface was not found to avoid
>spamming logs with such configurations.
>
>Closes: https://gitlab.com/libvirt/libvirt/-/issues/514
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>---
> src/remote/remote_daemon.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
>index d880711c91..d4d999e53a 100644
>--- a/src/remote/remote_daemon.c
>+++ b/src/remote/remote_daemon.c
>@@ -97,6 +97,7 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority)
>     case VIR_ERR_NO_STORAGE_VOL:
>     case VIR_ERR_NO_NODE_DEVICE:
>     case VIR_ERR_NO_INTERFACE:
>+    case VIR_ERR_MULTIPLE_INTERFACES:
>     case VIR_ERR_NO_NWFILTER:
>     case VIR_ERR_NO_NWFILTER_BINDING:
>     case VIR_ERR_NO_SECRET:
>-- 
>2.41.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230802/89a0d52e/attachment.sig>


More information about the libvir-list mailing list