[PATCH 06/13] virfirewalld: Drop useless memset() in virFirewallDApplyRule()

Michal Privoznik mprivozn at redhat.com
Thu Aug 3 10:36:13 UTC 2023


This is a residue of v6.8.0-rc1~100. The error variable inside of
virFirewallDApplyRule() is already initialized to NULL. There's
no need to memset() it to zero again.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virfirewalld.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c
index 6fc54f357d..827e201dbb 100644
--- a/src/util/virfirewalld.c
+++ b/src/util/virfirewalld.c
@@ -360,8 +360,6 @@ virFirewallDApplyRule(virFirewallLayer layer,
     if (!sysbus)
         return -1;
 
-    memset(&error, 0, sizeof(error));
-
     if (!ipv) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("Unknown firewall layer %1$d"),
-- 
2.41.0



More information about the libvir-list mailing list