[PATCH 0/5] introduce support for block device properties

[Ján Tomko]

[Adding Lin to CC]

On a Wednesday in 2023, Kristina Hanicova wrote:
>I noticed this on the list after the 1849570 bug on discard granularity:
>https://listman.redhat.com/archives/libvir-list/2020-June/203862.html
>so I decided to add maximum unmap size as well.
>

Looks like there was no reply to that series - was it just forgotten or
does anyone have any objections against it?

>The series is heavily based on Lin's patches and I would be glad if
>there is any way to add Lin into commit messages as well.
>

Depending on how much of the patches you kept, you can keep the original
author's name there (if you did not apply the patches via `git am`,
you can change the author via `commit --amend --author` and also add
your signoff, possibly stating what you changed), or mention the
original author in the commit message (I see we used a
"Based-on-work-of" tag once in history)

Also, please describe the changes the patches do in the commit messages,
all of them are empty.

Jano

>Kristina Hanicova (5):
>  conf: add support for discard_granularity
>  qemu: add support for discard_granularity
>  conf: add support for max_unmap_size
>  qemu: Introduce QEMU_CAPS_SCSI_DISK_MAX_UNMAP_SIZE capability
>  qemu: add support for max_unmap_size
>
> docs/formatdomain.rst                         | 16 +++++++-
> src/conf/domain_conf.c                        | 22 ++++++++++-
> src/conf/domain_conf.h                        |  2 +
> src/conf/domain_validate.c                    |  4 +-
> src/conf/schemas/domaincommon.rng             | 10 +++++
> src/qemu/qemu_capabilities.c                  |  2 +
> src/qemu/qemu_capabilities.h                  |  1 +
> src/qemu/qemu_command.c                       |  4 ++
> src/qemu/qemu_domain.c                        |  4 ++
> src/vz/vz_utils.c                             |  4 +-
> .../caps_4.2.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_4.2.0_ppc64.xml |  1 +
> .../qemucapabilitiesdata/caps_4.2.0_s390x.xml |  1 +
> .../caps_4.2.0_x86_64.xml                     |  1 +
> .../caps_5.0.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_5.0.0_ppc64.xml |  1 +
> .../caps_5.0.0_riscv64.xml                    |  1 +
> .../caps_5.0.0_x86_64.xml                     |  1 +
> .../qemucapabilitiesdata/caps_5.1.0_sparc.xml |  1 +
> .../caps_5.1.0_x86_64.xml                     |  1 +
> .../caps_5.2.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml |  1 +
> .../caps_5.2.0_riscv64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_5.2.0_s390x.xml |  1 +
> .../caps_5.2.0_x86_64.xml                     |  1 +
> .../caps_6.0.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_6.0.0_s390x.xml |  1 +
> .../caps_6.0.0_x86_64.xml                     |  1 +
> .../caps_6.1.0_x86_64.xml                     |  1 +
> .../caps_6.2.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 +
> .../caps_6.2.0_x86_64.xml                     |  1 +
> .../caps_7.0.0_aarch64+hvf.xml                |  1 +
> .../caps_7.0.0_aarch64.xml                    |  1 +
> .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 +
> .../caps_7.0.0_x86_64.xml                     |  1 +
> .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 +
> .../caps_7.1.0_x86_64.xml                     |  1 +
> tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 +
> .../caps_7.2.0_x86_64+hvf.xml                 |  1 +
> .../caps_7.2.0_x86_64.xml                     |  1 +
> .../caps_8.0.0_riscv64.xml                    |  1 +
> .../caps_8.0.0_x86_64.xml                     |  1 +
> .../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  1 +
> .../caps_8.1.0_x86_64.xml                     |  1 +
> .../disk-blockio.x86_64-latest.args           |  2 +-
> tests/qemuxml2argvdata/disk-blockio.xml       |  2 +-
> ...csi-disk-max_unmap_size.x86_64-latest.args | 37 +++++++++++++++++++
> .../disk-scsi-disk-max_unmap_size.xml         | 28 ++++++++++++++
> tests/qemuxml2argvtest.c                      |  1 +
> 50 files changed, 168 insertions(+), 6 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-max_unmap_size.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-max_unmap_size.xml
>
>-- 
>2.41.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230809/042d1b47/attachment.sig>