[libvirt PATCH v2 2/2] capabilities: report full external snapshot support

[Peter Krempa]

On Thu, Aug 24, 2023 at 18:21:41 +0200, Pavel Hrdina wrote:
> Now that deleting and reverting external snapshots is implemented we can
> report that in capabilities so management applications can use that
> information and start using external snapshots.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  docs/formatcaps.rst                            | 6 ++++++
>  src/conf/capabilities.c                        | 1 +
>  src/conf/capabilities.h                        | 1 +
>  src/conf/schemas/capability.rng                | 5 +++++
>  src/qemu/qemu_capabilities.c                   | 1 +
>  tests/qemucaps2xmloutdata/caps.aarch64+hvf.xml | 1 +
>  tests/qemucaps2xmloutdata/caps.aarch64.xml     | 1 +
>  tests/qemucaps2xmloutdata/caps.ppc.xml         | 1 +
>  tests/qemucaps2xmloutdata/caps.ppc64.xml       | 1 +
>  tests/qemucaps2xmloutdata/caps.riscv64.xml     | 1 +
>  tests/qemucaps2xmloutdata/caps.s390x.xml       | 1 +
>  tests/qemucaps2xmloutdata/caps.sparc.xml       | 1 +
>  tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml  | 1 +
>  tests/qemucaps2xmloutdata/caps.x86_64.xml      | 1 +
>  14 files changed, 23 insertions(+)
> 
> diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst
> index bb8bc663d2..255180135d 100644
> --- a/docs/formatcaps.rst
> +++ b/docs/formatcaps.rst
> @@ -134,6 +134,11 @@ The ``<guest/>`` element will typically wrap up the following elements:
>        creating external disk snapshots is supported. If absent, creating external
>        snapshots may still be supported, but it requires attempting the API and
>        checking for an error to find out for sure. :since:`Since 1.2.3`
> +   ``externalSnapshot``
> +      If this element is present, the hypervisor supports deleting and
> +      reverting external snapshots including memory state. Creating external
> +      snapshots is supported for long time.

"Support for creation of external snapshots is reported via the
`disksnapshot` feature flag."

Reviewed-by: Peter Krempa <pkrempa at redhat.com>