[PATCH 00/27] Move error messages onto a single line
Michal Prívozník
mprivozn at redhat.com
Fri Aug 25 10:52:51 UTC 2023
On 8/25/23 12:14, Pavel Hrdina wrote:
> On Fri, Aug 25, 2023 at 09:39:57AM +0200, Michal Privoznik wrote:
>> This is inspired by the following discussion:
>>
>> https://listman.redhat.com/archives/libvir-list/2023-August/241361.html
>
> We have it covered by coding style document so it would be nice to make
> a syntax-check for it as well so there are no new multi-line errors
> introduced in the future. Not sure how difficult it would be so
> definitely as follow up.
Yeah, I was thinking about that, but I'm not that good with RE-s.
>
> Otherwise looks good and compiles without issues on my machine.
>
> I would consider pushing it after release is done to make sure it will
> not break anything as it affects basically the whole libvirt code base.
I hear you and I agree. And given how huge the change is I'd rather push
it right after the release to avoid any conflicts.
>
>> And ideally I'd present a green pipeline but for some reason, I can't:
>>
>> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262
>>
>> But the problem is not with my code rather than our CI.
>
> Unless there are objections from others
>
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
Thank you!
Michal
More information about the libvir-list
mailing list