[PATCH 07/10] virt-ssh-helper: Accept ?socket= in connection URI
Peter Krempa
pkrempa at redhat.com
Tue Feb 7 08:17:52 UTC 2023
On Mon, Feb 06, 2023 at 10:16:55 +0100, Michal Privoznik wrote:
> Similarly to the previous commit, let's accept "socket" parameter
> in the connection URI. This change will allow us to use
> virt-ssh-helper instead of 'nc' in all cases (done in one of
> future commits).
>
> Please note, when the parameter is used it effectively disables
> automatic daemon spawning and an error is reported. But this is
> intentional - so that the helper behaves just like regular
> virConnectOpen() with different transport than ssh, e.g. unix.
>
> But this 'change' is acceptable - there's no way for users to
> make our remote code pass the argument to virt-ssh-helper, yet.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/remote/remote_ssh_helper.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list