[PATCH] remote_driver: Work around broken clang

Michal Privoznik mprivozn at redhat.com
Thu Feb 9 08:19:13 UTC 2023


In recent commit of v9.0.0-191-gc71c159248 I've introduced
remoteConnectFormatURI() function and in the function @query
variable. Even though, the variable is used, clang-13 fails to
see it. Surprisingly, never clang is not affected. Fortunately,
swapping the order in which variables are set makes clang happy
again.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/remote/remote_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 58cd0abe8c..a4c60be3d7 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -712,7 +712,7 @@ remoteConnectFormatURI(virURI *uri,
         virURIParamsSetIgnore(uri, false, names);
     }
 
-    query = tmpuri.query = virURIFormatParams(uri);
+    tmpuri.query = query = virURIFormatParams(uri);
 
     ret = virURIFormat(&tmpuri);
 
-- 
2.39.1



More information about the libvir-list mailing list