[PATCH] qemuProcessRefreshDisks: Don't skip filling of disk information if tray state didn't change

Ján Tomko jtomko at redhat.com
Thu Feb 9 10:16:43 UTC 2023


On a Thursday in 2023, Peter Krempa wrote:
>Commit 5ef2582646eb98 added emitting of even when refreshign disk state,

*refreshing

>where it wanted to avoid sending the event if disk state didn't change.
>This was achieved by using 'continue' in the loop filling the
>information. Unfortunately this skips extraction of whether the device
>has a tray which is propagated into internal structures, which in turn
>broke cdrom media change as the code thought there's no tray for the
>device.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2166411
>Fixes: 5ef2582646eb98af208ce37355f82bdef39931fa
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_process.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

Commit-message-spellchecked-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230209/8fe8e66b/attachment.sig>


More information about the libvir-list mailing list